Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add finally block for restoring original model in profiling #795

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

palday
Copy link
Member

@palday palday commented Dec 9, 2024

addresses part of #794

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.08%. Comparing base (2f92408) to head (8a67eff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
+ Coverage   96.93%   97.08%   +0.15%     
==========================================
  Files          33       33              
  Lines        3397     3401       +4     
==========================================
+ Hits         3293     3302       +9     
+ Misses        104       99       -5     
Flag Coverage Δ
current 96.79% <100.00%> (+0.15%) ⬆️
minimum 97.02% <100.00%> (+0.15%) ⬆️
nightly 96.72% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palday palday requested a review from ararslan December 9, 2024 22:23
src/profile/profile.jl Outdated Show resolved Hide resolved
@palday palday merged commit 7103ee1 into main Dec 10, 2024
12 checks passed
@palday palday deleted the pa/profile_recovery branch December 10, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants